Log and throw anti-pattern detected

[uffe_w]

We have a situation where client code sometimes cancels the request to generate a preview and that means that the parser in docx4j will throw an exception. The exception ends up in the XMLUtils inner class LoggingErrorListener, which in case of a fatal error both logs and throws the exception.
We would prefer that the exceptions only were thrown and not logged so we can handle them ourselves in our code and not have docx4j log a complete stacktrace every time this happens.

Can this be changed?

[jason]

Makes sense, how about https://github.com/plutext/docx4j/commi ... db4acfef6d

Unfortunately, this just missed v3.3.2

[uffe_w]

Thanks, that will do nicely

Looking forward to v3.3.3 then...

[uffe_w]

I think the problem is in AbstractExporter.export() as well, can the problem be fixed there too?

} catch (Exception e) {
log.error("Exception exporting package", e);
throw new Docx4JException("Exception exporting package", e);
}

This is actually exactly why the log and throw antipattern should be avoided. Now the same stacktrace is logged more than once.