System.out.printlns?

[jbeltran]

Hi all,

I'm using docx4j in a web application and the application logs are getting littered with System.out.printlns? Are there any plans to remove those from the application?

If not, is the best way to deal with it simply to download the source and comment all the printlns and then build a new docx4j jar?

Thanks,
Justin

[jason]

I'm using docx4j in a web application and the application logs are getting littered with System.out.printlns?

True.

Are there any plans to remove those from the application?

Yes, just haven't gotten around to it yet (even though its a 10 min job).

If not, is the best way to deal with it simply to download the source and comment all the printlns and then build a new docx4j jar?

Sure, you can do that. Otherwise you can wait, but it may be several weeks before I can upload a nightly build.

cheers .. Jason

[jason]

This is now fixed in my local copy; its just a matter of committing it.

[clarke]

We have a huge (old legacy java) code-base, where many files (around 5k) have System.out.println's. We are planning to remove them for cleanup/performance reasons. How can we write a script that will replace them without introducing any issues in the code? The script cannot blindly delete them as following case can be an issue:

if ()
some.code...
else
System.out.println(...);
DB.close();

I'm thinking of replacing them with ';'. That will take care of above case. Do you see any other issues? Any other suggestions?

[jason]

If it were me, I'd be hesitant to obliterate them like that, since they probably contain some knowledge relating to the system.

I think I'd replace them with calls to one of the logging frameworks, but at debug level, so you never need to see them unless you want to. Progressively over time, you could change the log levels or remove some of the logging statements entirely.